[PATCH] Remove fstring from wb_acct_info

Jeremy Allison jra at samba.org
Thu Nov 1 16:28:52 UTC 2018


On Thu, Nov 01, 2018 at 11:54:28AM +0100, Volker Lendecke via samba-technical wrote:
> On Thu, Nov 01, 2018 at 11:43:03AM +0200, Uri Simchoni via samba-technical wrote:
> > We win by not trying to enumerate all groups (or users), using a filter
> > instead, and returning at most 1000 entries.
> > 
> > For the use case of finding a group, even if you can get all groups,
> > would you let a user browse through hundreds of thousands of results? Or
> > would you offer some search capability? If you do search, then its best
> > to go:
> > - user types something
> > - user stops typing, or clicks "search" button
> > - send query with what the user typed as filter. If the query returns
> > more than 1000, he should narrow it anyway. Tell him to do so.
> 
> We should remove that from core winbind. To get there, what about
> streamlining and documenting a "net search" command doing the LDAP
> queries?

That is an *excellent* idea !



More information about the samba-technical mailing list