[PATCH] even more python patches
Noel Power
nopower at suse.com
Thu Nov 1 14:37:10 UTC 2018
Hi Douglas
On 01/11/2018 10:02, Noel Power wrote:
>>
>>> @@ -115,7 +115,6 @@ def get_server_ref_from_samdb(samdb):
>>>
>>>
>>> class
>>> RodcRwdcCachedTests(password_lockout_base.BasePasswordTestCase):
>>> - counter = itertools.count(1).next
>>>
>>> def _check_account_initial(self, dn):
>>> self.force_replication()
>>> @@ -686,7 +685,7 @@ class
>>> RodcRwdcCachedTests(password_lockout_base.BasePasswordTestCase):
>>>
>>>
>>> class RodcRwdcTests(password_lockout_base.BasePasswordTestCase):
>>> - counter = itertools.count(1).next
>>> + counter = itertools.count(1,1)
>>>
>>> def force_replication(self, base=None):
>>> if base is None:
>>> @@ -982,7 +981,7 @@ class
>>> RodcRwdcTests(password_lockout_base.BasePasswordTestCase):
>>> self._test_add_modify_delete()
>>>
>>> def _new_user(self):
>>> - username = "u%sX%s" % (self.tag[:12], self.counter())
>>> + username = "u%sX%s" % (self.tag[:12], next(self.counter()))
>>> password = 'password#1'
>>> dn = 'CN=%s,CN=Users,%s' % (username, self.base_dn)
>>> o = {
>>>
>> should work and is probably best. Could you please try it?
>
> what I meant was I tried the code snippet [1] locally and it seems to
> work the same as the orig code but not any real testing e.g. CI, lets
> see what the CI says (I am hopefull!!)
>
> Noel
Here is the branch, patches (attached) and CI, can I have your RB for
the last patch
CI: https://gitlab.com/samba-team/devel/samba/pipelines/35090598
Branch:
https://gitlab.com/samba-team/devel/samba/commits/npower-douglas-python-a-little-bit-more
thanks,
Noel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remainder-little-more.patch
Type: text/x-patch
Size: 17328 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181101/5dcb3f3a/remainder-little-more.bin>
More information about the samba-technical
mailing list