[PATCH] remove "ExistingBackend" provision backend and 28 other python patches

Noel Power nopower at suse.com
Thu Nov 1 10:05:01 UTC 2018

On 31/10/2018 20:57, Douglas Bagnall wrote:
> On 31/10/18 11:47 PM, Noel Power wrote:
>>   [PATCH 24/29] python/ms_forest_updates_markdown: avoid implicit
>>   global variable
>> -    read_ms_markdown(in_file, out_folder)
>> +    read_ms_markdown(in_file, out_folder, {})
>> That looks wrong to me, read_ms_markdown looks like it takes a file or
>> dictionary, it looks like the code will prefer the file if both are
>> specified but read_ms_markdown should either pass a temp dict to
>> save_array routine or save_array should handle the None dict, it should
>> handle the None default gracefully
> Right. It just needs the attached version then? I think you are right
> and it looks clearer.



More information about the samba-technical mailing list