[PATCH] ldb: Fix memory leak on module context

Lukas Slebodnik lslebodn at fedoraproject.org
Thu May 31 11:21:00 UTC 2018


On (31/05/18 10:47), Andrew Bartlett via samba-technical wrote:
>On Thu, 2018-05-31 at 00:08 +0200, Lukas Slebodnik via samba-technical
>wrote:
>> ehlo,
>> 
>> Memory leak was introduced in 1.3.0.
>> I just forgot to sent patch to upstream.
>> 
>> So maybe you might consider to backport also to older branches.
>
>Can you file a bug for that?
>

I do not need I am fine with waiting to new release and drop patch later.
I wrote just in case because I am not sure what is a relation to latest libldb
and stable version of samba.

>Also can you send in your DCO per the contributing page and use the
>same e-mail address as you use for that?
>
Done

LS
-------------- next part --------------
From 6c78935344a4f086fc209d0bd77feac0ea5894b3 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at fedoraproject.org>
Date: Sat, 21 Oct 2017 15:09:01 +0200
Subject: [PATCH] ldb: Fix memory leak on module context

Introduced in e8cdacc509016d9273d63faf334d9f827585c3eb

Signed-off-by: Lukas Slebodnik <lslebodn at fedoraproject.org>
---
 lib/ldb/ldb_tdb/ldb_index.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/ldb/ldb_tdb/ldb_index.c b/lib/ldb/ldb_tdb/ldb_index.c
index c71e866037c5cccba151bcd2346460de0424fe18..1d69ab27f20e0a367c982134ff16a06b044a0c8e 100644
--- a/lib/ldb/ldb_tdb/ldb_index.c
+++ b/lib/ldb/ldb_tdb/ldb_index.c
@@ -516,9 +516,9 @@ static int ltdb_dn_list_store_full(struct ldb_module *module,
 	if (list->count == 0) {
 		ret = ltdb_delete_noindex(module, msg);
 		if (ret == LDB_ERR_NO_SUCH_OBJECT) {
-			talloc_free(msg);
-			return LDB_SUCCESS;
+			ret = LDB_SUCCESS;
 		}
+		talloc_free(msg);
 		return ret;
 	}
 
-- 
2.14.2



More information about the samba-technical mailing list