[PATCH] Fix selftest resolv_wrapper config

Jeremy Allison jra at samba.org
Wed May 30 17:06:45 UTC 2018


On Wed, May 30, 2018 at 05:06:31PM +0200, Volker Lendecke via samba-technical wrote:
> Hi!
> 
> Review apprecated!
> 
> Thanks, Volker

LGTM. RB+ and pushed - nice catch !

Jeremy.

> -- 
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de

> From eb1e5f726a7ea707d173b7c80688e33c2a13ee7c Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Wed, 30 May 2018 17:03:55 +0200
> Subject: [PATCH] selftest: Fix resolv_wrapper config variables
> 
> It can't really matter in this case, but it removes confusion
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  selftest/target/Samba3.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
> index c6ae7abcfa6..a553405db0d 100755
> --- a/selftest/target/Samba3.pm
> +++ b/selftest/target/Samba3.pm
> @@ -2269,9 +2269,9 @@ force_user:x:$gid_force_user:
>  	$createuser_env{NSS_WRAPPER_HOSTS} = $nss_wrapper_hosts;
>  	$createuser_env{NSS_WRAPPER_HOSTNAME} = "${hostname}.samba.example.com";
>  	if ($ENV{SAMBA_DNS_FAKING}) {
> -		$createuser_env{RESOLV_WRAPPER_CONF} = $resolv_conf;
> -	} else {
>  		$createuser_env{RESOLV_WRAPPER_HOSTS} = $dns_host_file;
> +	} else {
> +		$createuser_env{RESOLV_WRAPPER_CONF} = $resolv_conf;
>  	}
>  
>  	createuser($self, $unix_name, $password, $conffile, \%createuser_env) || die("Unable to create user");
> -- 
> 2.11.0
> 




More information about the samba-technical mailing list