[PATCH] samba-tool schema attribute query_oc

Andrew Bartlett abartlet at samba.org
Tue May 29 04:01:31 UTC 2018

On Mon, 2018-05-28 at 12:31 +1000, William Brown wrote:
> Here you go. Updated based on your feedback. 
> Link to branch:
> https://gitlab.com/Firstyear/samba/tree/configure
> Link to CI:
> https://gitlab.com/Firstyear/samba/pipelines/22732250
> I suspect CI will fail but running quicktest on my machine this seems
> mdb related?

Garming and I have reviewed this sub-set:

python/samba/netcmd/schema.py: samdb schema update now
python/samba/tests/samba_tool/schema.py: Improve schema command testing
python/samba/netcmd/schema.py: add schema show_oc for attribute
python/samba/netcmd/schema.py: add schema query and management.
python/samba/netcmd/group.py: add group show
python/samba/netcmd/{forest.py,main.py}: add configuration controls

For those we missed:

The external schema code seems to duplicate a little of what we have
elsewhere in the dcpromo code.  Also, the changes should at least be
wrapped in a transaction, so that we don't have partially loaded schema
(the add but not a modify). 

The domain options are weird in that it only manipulates an option we
don't have.  I agree with the principle but we need to start with (or
at least have) an option we support as well. 

The dsacl code has no expected value tests, it should check the ACL got
set correctly on the directory as well as the correct output.  It also
has a commented out "replace" operation, which made me wonder if the
patch was finished. 

The schema search and flag changes are the most mature so we have
accepted those. 

I'm sorry this has been so long and look forward to working with you on
the remainder.  I'm particularly sorry for the strong feedback at this
late stage. 


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list