[PATCH] Password Settings Object (PSO) support for Samba

[William Brown]

On Tue, 2018-05-22 at 17:50 +1200, Tim Beale via samba-technical wrote:
> Hi,
> 
> Attached is the latest patch-set that contains the functional changes
> required to support PSOs. Changes can also be viewed here:
> https://gitlab.com/catalyst-samba/samba/commits/tim-pso
> 
> And proof they run through the CI tests successfully here:
> https://gitlab.com/catalyst-samba/samba/pipelines/22403197
> 
> Note: the domain.py file move work is still waiting for the backup
> changes to go in first (I haven't forgotten about it).

Sorry I didn't comment more. I did just find the runsublevelcmd you
added, and it was super useful. Thank you :) 

I think it's already merged now, but I'll try and read the patches
later anyway,

Thanks! 

> 
> Thanks,
> Tim
> 
> On 16/05/18 19:58, William Brown via samba-technical wrote:
> > On Wed, 2018-05-16 at 19:50 +1200, Andrew Bartlett wrote:
> > > On Wed, 2018-05-16 at 11:28 +1200, Tim Beale via samba-technical
> > > wrote:
> > > > Hi William,
> > > > 
> > > > Thanks for the feedback. That's a good point about the netcmd
> > > > code
> > > > layout.
> > > > 
> > > > Given that the new PSO samba-tool code is pretty self-
> > > > contained,
> > > > and
> > > > domain.py is already 4000+ lines long, I think it'd make sense
> > > > to
> > > > keep
> > > > it as a separate file.
> > > > 
> > > > However, one problem is the python import won't like having
> > > > both a
> > > > domain.py file and a domain/ sub-directory. So are you
> > > > suggesting
> > > > that I
> > > > move netcmd/domain.py --> netcmd/domain/__init__.py? I just
> > > > thought
> > > > I'd
> > > > double-check, as that might have ramifications for other people
> > > > with
> > > > back-porting patches, or for work in progress changes, etc.
> > > 
> > > I think this (the rename of domain.py -> domain/__init__.py) is
> > > the
> > > most resaonble, but once we land the backup changes so as not to
> > > make
> > > that any harder than is already is.  
> > 
> > This is what I meant :) 
> > 
> > I have some changes to domain.py too I think in my recent patchsets
> > ...
> > 
> > > Thanks,
> > > 
> > > Andrew Bartlett
> 
> 
-- 
Sincerely,

William