ldb one-level search performance issue

[Andrew Bartlett]

On Fri, 2018-05-25 at 17:39 +1200, Andrew Bartlett via samba-technical
wrote:
> On Fri, 2018-05-25 at 06:25 +0200, Stefan Metzmacher wrote:
> > Am 23.05.2018 um 20:55 schrieb Andrew Bartlett via samba-technical:
> > > On Wed, 2018-05-23 at 12:43 +0200, Stefan Metzmacher wrote:
> > > > Hi Andrew,
> > > > 
> > > > > I've uploaded the patches with tests to
> > > > > https://gitlab.com/catalyst-samba/samba/commits/tim-ldb-fix
> > > > > 
> > > > > and the CI is here:
> > > > > 
> > > > > https://gitlab.com/catalyst-samba/samba/pipelines/22482561
> > > > > 
> > > > > If that passes, please review and push so we can then do the release
> > > > > (after the python build fix).
> > > > 
> > > > "ldb: Add tests for when we should expect a full scan" fails
> > > > "autobuild-private ldb"
> > > > 
> > > > metze
> > > 
> > > Thanks!
> > > 
> > > I see two lessons here:
> > > 
> > > - This is a great example of why pre-submission CI is really important,
> > > so we don't waste time on bung patches
> > > - Doing patches in the rush out the door before dinner with the family
> > > never ends well.  The family dinner is more important than the patch,
> > > which will always need rework in the morning anyway :-)
> > > 
> > > https://gitlab.com/catalyst-samba/samba/pipelines/22531454
> > > 
> > > (Also already passing a local make test on ldb). 
> > > 
> > > If this one passes, please review and push!
> > 
> > I tried, but it seems to consistently fail with:
> > 
> > [851(6535)/853 at 2h13m26s]
> > samba4.blackbox.dbcheck(ad_dc_ntvfs)(ad_dc_ntvfs:local)
> > WARNING: The "lsa over netlogon" option is deprecated
> > WARNING: The "server schannel" option is deprecated
> > WARNING: The "lsa over netlogon" option is deprecated
> > WARNING: The "server schannel" option is deprecated
> > WARNING: The "lsa over netlogon" option is deprecated
> > WARNING: The "server schannel" option is deprecated
> > UNEXPECTED(failure):
> > samba4.blackbox.dbcheck(ad_dc_ntvfs).dbcheck(ad_dc_ntvfs:local)
> > REASON: Exception: Exception: WARNING: The "lsa over netlogon" option is
> > deprecated
> > WARNING: The "server schannel" option is deprecated
> > Checking 18786 objects
> > NOTE: old (due to rename or delete) DN string component for
> > defaultObjectCategory in object
> > CN=DrsReplSchema-1527199312-1-cls-B-NEW,CN=Schema,CN=Configuration,DC
> > =samba,DC=example,DC=com -
> > <GUID=2051e2f9-6b4b-47d1-b146-4b8d7aedf49d>;CN=DrsReplSchema-1527199312-1-cls-B,CN=Schema,CN=Configuration,DC=samba,DC=example,DC=com
> > Not fixing old string component
> > NOTE: old (due to rename or delete) DN string component for
> > defaultObjectCategory in object
> > CN=DrsReplSchema-1527199258-1-cls-B-NEW,CN=Schema,CN=Configuration,DC=samba,DC=example,DC=com
> 
> Thanks.  I've been trying to pretend it was just a flapping test,
> fixing other flapping test and blaming gitlab for generally perturbing
> the state.  This seems a much more plausible.
> 
> Tim and I are working on a fix for dbcheck (see attached) and tests,
> but the question of why this test now fails remains. 

The string component stuff was a red herring (as it would not throw an
error), but it hid this real issue:

Checking 18862 objects
ERROR: parent object not found for CN=kcc_BCDE3

Patches to get that far are in 

https://gitlab.com/catalyst-samba/samba/commits/abartlet-dbcheck-ideas

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba