[s3] CID 1427623 and possible memory leak

[Volker Lendecke]

On Fri, May 25, 2018 at 11:04:52AM +0200, Swen Schillig via samba-technical wrote:
> From 500b7733730d8186e03e236a467d12ddbb32e399 Mon Sep 17 00:00:00 2001
> From: Swen Schillig <swen at vnet.ibm.com>
> Date: Fri, 25 May 2018 10:46:52 +0200
> Subject: [PATCH 2/2] [s3] CID 1427623: Explicit NULL dereference.
> 
> Signed-off-by: Swen Schillig <swen at vnet.ibm.com

Can you explain how this fixes 1427623? 1427623 is in winbindd_pam.c.
I would rather fix this in winbindd_pam.c. Coverity is very bad at
understanding NTSTATUS, there is TONS of those defects.

Can you figure out how to tell Coverity that in winbindd_pam.c "info3"
is !=NULL if and only if NT_STATUS_OK(result) is true? This would fix
dozens of defects in one run.

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de