ldb one-level search performance issue

[Andrew Bartlett]

On Wed, 2018-05-23 at 07:09 +1200, Andrew Bartlett via samba-technical
wrote:
> On Tue, 2018-05-22 at 20:52 +0200, Stefan Metzmacher wrote:
> > 
> > And there's a 'tim-ldb-fix' branch with
> > ldb: One-level search was incorrectly falling back to full DB scan
> 
> Yes.  If a search using a one-level index was could not be resolved
> using the index records, it would fall back to a full scan.  This is a
> regression introduced when we tried to fix the DNS performance issue
> around Christmas by adding the intersection between the one-level and
> filter index.
> 
> > Do we also need that for 1.4.0?
> 
> Yes.
> 
> > And maybe also in older releases?
> 
> Yes.
> 
> Andrew Bartlett

I've uploaded the patches with tests to
https://gitlab.com/catalyst-samba/samba/commits/tim-ldb-fix

and the CI is here:

https://gitlab.com/catalyst-samba/samba/pipelines/22482561

If that passes, please review and push so we can then do the release
(after the python build fix).

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba