[PATCH] socket_wrapper: Add missing dependency on tirpc

[Andreas Schneider]

On Tuesday, 22 May 2018 04:23:02 CEST Amitay Isaacs wrote:
> On Fri, May 18, 2018 at 5:41 PM, Amitay Isaacs <amitay at gmail.com> wrote:
> > On Thu, May 17, 2018 at 3:54 PM, Andreas Schneider <asn at samba.org> wrote:
> >> On Monday, 14 May 2018 09:02:39 CEST Amitay Isaacs via samba-technical 
wrote:
> >>> Hi,
> >>> 
> >>> On fedora 28, socket_wrapper fails to build without tirpc dependency.
> >> 
> >> Why does it need tirpc? What's the error?
> > 
> > Here's the error:
> > 
> > $ make
> > WAF_MAKE=1 PATH=buildtools/bin:../buildtools/bin:$PATH waf build
> > Waf: Entering directory `/home/amitay/samba/samba-ctdb.git/ctdb/bin'
> > [ 57/386] Compiling ../third_party/socket_wrapper/socket_wrapper.c
> > ../../third_party/socket_wrapper/socket_wrapper.c:80:10: fatal error:
> > rpc/rpc.h: No such file or directory
> > 
> >  #include <rpc/rpc.h>
> >  
> >           ^~~~~~~~~~~
> > 
> > compilation terminated.
> > Waf: Leaving directory `/home/amitay/samba/samba-ctdb.git/ctdb/bin'
> > 
> > Build failed:  -> task failed (err #1):
> >     {task: cc socket_wrapper.c -> socket_wrapper_1.o}
> > 
> > make: *** [Makefile:6: all] Error 1
> > 
> > Here's what in my config.h
> > 
> > $ grep RPC bin/default/config.h
> > /* #undef HAVE_RPC_RPC_HEADERS */
> > #define HAVE_TIRPC 1
> > #define HAVE_RPC_RPC_H 1
> > #define HAVE_RPC_NETTYPE_H 1
> > 
> > 
> > Amitay.
> 
> Any other questions Andreas?  Commit 3029067b in socket_wrapper added
> dependency on <rpc/rpc.h>.  May be we should do it conditionally if we
> can't find bindresvport in <netinet/in.h>.
> 
> I would like to get some fix (either add explicit dependency on tirpc
> or conditional check for rpc/rpc.h header) upstream soon. It's a pain
> to keep adding a fix to every branch I want to build.
> 
> Amitay.

I think you can add the tirpc requirement. Just push your patch.

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org