[PATCH] LMDB full patch set

Andrew Bartlett abartlet at samba.org
Tue May 22 07:42:10 UTC 2018


On Sat, 2018-05-19 at 07:14 +1200, Andrew Bartlett via samba-technical
wrote:
> On Fri, 2018-05-18 at 13:13 +0200, Stefan Metzmacher wrote:
> > 
> > Thanks! I also compared autobuild times and got similar results.
> > 
> > One thing I was wondering about is if we should make use of virtual
> > databases within lmdb. 
> > I'm not asking to do that before we can push this, but we should
> > at least have ways for a seamless change in future. The compatibility
> > flags at the samba_dsdb level are not a valid way to detect this!
> > We need this at the ldb_lmdb layer.

> Yes, we have had many interesting ideas about ways we can properly
> leverage the virtual databases.  We certainly could solve a lot of
> problems that way, and (for example) if we use a sub-db per index we
> gain the ability to do >= searches but walking the keys in-order.
> 
> I agree, we shouldn't block on this.  Attached and included in the
> branch is a simple patch to recognise this probable future and abort on
> downgrade.

G'Day,

Having addressed all the various issues raised over the past weeks and
months, I would now like to push this to master.  

There will always be things to improve, but we will learn those best
when we have it available for use. 

I would like to push this in the next day or so.  

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list