[PATCH]dsdb partition.c make partition_copy_all async.

Andrew Bartlett abartlet at samba.org
Tue May 22 03:53:37 UTC 2018

G'Day Gary,

Here you unilaterally blot over error and run the copy without checking
if the original operation failed, returning the copy status and not the
original error:

On Tue, 2018-05-22 at 15:41 +1200, Gary Lockyer via samba-technical
> +       case LDB_REPLY_DONE:
> +               error = partition_copy_all_callback_action(
> +                       ac->module,
> +                       ac->partition_context,
> +                       ac->request,
> +                       ac->dn,
> +                       ares->error);

Otherwise it looks like what I would expect (which is incredible
amounts of boilerplate thanks to the aysnc LDB api). 


Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list