[PATCH] samba-tool schema attribute query_oc
Andrew Bartlett
abartlet at samba.org
Fri May 18 06:51:22 UTC 2018
On Fri, 2018-05-18 at 16:45 +1000, William Brown wrote:
> On Fri, 2018-05-18 at 18:39 +1200, Andrew Bartlett wrote:
> > You can just push a string value or set of string values back into
> > the
> > ldb message and then print it. It isn't read-only.
>
> So get the flags, change them, then push to write_ldif? This seems too
> easy ;)
:-)
> > We do that for plenty of other attributes. See lib/ldb-
> > samba/ldif_handlers.c
>
> Yes, but we'd be adding an attr that's "not in schema" technically. I
> think your solution above is better.
It certainly is easier to keep this in python for now.
> > Before I look at these again, can you push them to some kind of CI,
> > either github or gitlab?
>
> Sure, will do. I've been careful to run make test with these, but CI is
> good too :)
Thanks,
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list