[PATCHSET] Several fixes found by our tools

Andrew Bartlett abartlet at samba.org
Wed May 16 18:56:22 UTC 2018

On Wed, 2018-05-16 at 19:20 +0200, Andreas Schneider via samba-
technical wrote:
> Hi,
> I've packaged Samba for the next RHEL version and our internal tools found 
> several issues. Attached is a patchset which mostly fixes complaints by 
> Coverity.
> Please review and push if OK.

I've reviewed and pushed:
s3:smbd: Fix converity warning with _smb_setlen_large()
libcli: Fix coverity warning in smb2cli_notify_send()
s4:torture: Make sure variable is initialized in oplock test
s3:modules: Initialize pointers in vfs_virusfilter
s3:winbind: Initialize validation_level in winbind_dual_SamLogon()
s4:dsdb:tests: Add return code check
ctdb: Check return values of tevent_req_set_endtime()

Others I couldn't review before breakfast:

* I don't like the close(-1) patches, that seems harmless really. 
Someone else may however feel it is better to shut up the tool.

* The printf log patch I looked reversed and otherwise strange, so I've
left it for brighter eyes to check. 


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list