[PATCH] Remove extra 0x in the %p formatting string

[Timur I. Bakeyev]

On 12 May 2018 at 10:35, Martin Schwenke <martin at meltin.net> wrote:

> Hi Timur,
>
> > Hi all!
> >
> > While analyzing debug logs of our customer, I've noticed strange looking
> > lines like:
> >
> > [2018/05/09 16:02:52.629315, 10, pid=907, effective(1001, 1001), real(0,
> > 0)] ../source3/smbd/open.c:5543(create_file_default)
> >   create_file: access_mask = 0x100080 file_attributes = 0x10,
> share_access
> > = 0x7, create_disposition = 0x1 create_options = 0x1 oplock_request = 0x0
> > private_flags = 0x0 root_dir_fid = 0x0, ea_list = 0x0x0, sd = 0x0x0,
> fname
> > = .
> >
> > That 0x0x0 puzzled me and short investigation showed that in few places
> we
> > use "0x%p" format string to represent buffer address in the debug logs.
> Man
> > page for *printf says:
> >
> >      p           The void * pointer argument is printed in hexadecimal
> (as
> > if
> >                  by ‘%#x’ or ‘%#lx’).
> >
> > I.e. the address will be already prefixed with the 0x, no need to
> > explicitly add it.
> >
> > Here is a small patch.
>
> Looks good.
>
> For the changes in lib/dbwrap/dbwrap_tdb.c and source3/smbd/open.c, can
> you please modernise the debug statements that you touch by changing
> them as below?
>
>   DEBUG(10, (...));
>
> to
>
>   DBG_DEBUG(...);
>
> Thanks...
>
> With that:
>
> Reviewed-by: Martin Schwenke <martin at meltin.net>
>

Thanks for the review, Martin!

Here are the patches that should fit you requirements, I hope.

List, can I get a second review, please :)?

With regards,
Timur Bakeyev.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-extra-0x-prefix-for-the-p-format-specifiers-a.patch
Type: application/octet-stream
Size: 2990 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180516/0d57b9e0/0001-Remove-extra-0x-prefix-for-the-p-format-specifiers-a.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Convert-affected-by-previous-commit-lines-from-DEBUG.patch
Type: application/octet-stream
Size: 2821 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180516/0d57b9e0/0002-Convert-affected-by-previous-commit-lines-from-DEBUG.obj>