[PATCH] script: Add 'random-seed' option to traffic_replay

[William Brown]

On Wed, 2018-05-16 at 19:59 +1200, Andrew Bartlett via samba-technical
wrote:
> On Wed, 2018-05-16 at 17:39 +1200, Tim Beale via samba-technical
> wrote:
> > Hi,
> > 
> > The attach patch adds a new option to the traffic_replay tool that
> > allows you to seed the random number generator.
> > 
> > When you use a model-file to generate traffic, by default the tool
> > creates random variation in the packets that it actually generates.
> > However, this makes it hard to measure changes in samba performance
> > over
> > time, i.e. differences could be just due to random variation in the
> > types/number of packets sent, rather than due to the Samba code
> > getting
> > better/worse. Using the --random-seed option means an identical set
> > of
> > packets gets produced across several different test runs.
> 
> This got a positive CI result here:
> 
> https://gitlab.com/catalyst-samba/samba/pipelines/22091844
> 
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> 
> Can I get a second team reviewer please?

I'm not a team member, but the patch looks good to me :) 

> 
> Thanks,
> 
> Andrew Bartlett
>