[PATCH] Password Settings Object (PSO) support for Samba

Andrew Bartlett abartlet at samba.org
Wed May 16 07:50:47 UTC 2018

On Wed, 2018-05-16 at 11:28 +1200, Tim Beale via samba-technical wrote:
> Hi William,
> Thanks for the feedback. That's a good point about the netcmd code layout.
> Given that the new PSO samba-tool code is pretty self-contained, and
> domain.py is already 4000+ lines long, I think it'd make sense to keep
> it as a separate file.
> However, one problem is the python import won't like having both a
> domain.py file and a domain/ sub-directory. So are you suggesting that I
> move netcmd/domain.py --> netcmd/domain/__init__.py? I just thought I'd
> double-check, as that might have ramifications for other people with
> back-porting patches, or for work in progress changes, etc.

I think this (the rename of domain.py -> domain/__init__.py) is the
most resaonble, but once we land the backup changes so as not to make
that any harder than is already is.  


Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list