[PATCH] Re: [WIP] Log database changes.
abartlet at samba.org
Wed May 16 00:30:47 UTC 2018
On Tue, 2018-05-15 at 16:59 -0700, Jeremy Allison wrote:
> On Wed, May 16, 2018 at 11:46:29AM +1200, Andrew Bartlett wrote:
> > G'Day Jeremy.
> > Just to make sure I understand you. As I'm sure you have seen, this
> > patch just moves the existing helper functions (the work Gary did about
> > a year ago) into a mini-library and places it in another folder, which
> > is why it added the above documentation.
> "I'm sure you have seen" - nope. As I'm sure you
> know I haven't seen :-).
> Just to confirm, I don't see this code currently in
> the tree so it is new stuff being added, yeah ?
It is currently in auth/auth_log.c. It was probably a good place to
hide, I know nobody reads auth code ;-)
> I just *hate* that idiom for new API's, don't think
> we should expand it.
> > Are you asking that I not merge this series, or can I merge this much
> > and then you work with Gary to improve the API it as part of his
> > ongoing work stream?
> No, I don't want to block things - so you can merge
> if you need to. I would like to work with Gary to
> get this fixed though, I don't want it left like
> this long term.
Thanks. I saw Gary go through the phases of anger, grief and
resignation and he plans to go over it and make it return-based soon.
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
More information about the samba-technical