[PATCH] Password Settings Object (PSO) support for Samba

Tim Beale timbeale at catalyst.net.nz
Tue May 15 23:28:54 UTC 2018

Hi William,

Thanks for the feedback. That's a good point about the netcmd code layout.

Given that the new PSO samba-tool code is pretty self-contained, and
domain.py is already 4000+ lines long, I think it'd make sense to keep
it as a separate file.

However, one problem is the python import won't like having both a
domain.py file and a domain/ sub-directory. So are you suggesting that I
move netcmd/domain.py --> netcmd/domain/__init__.py? I just thought I'd
double-check, as that might have ramifications for other people with
back-porting patches, or for work in progress changes, etc.

I guess another option might be to have a more generically named
sub-directory, e.g.


The python import would then look something like: from
samba.netcmd.subcmd.pso import cmd_domain_passwordsettings_pso

Let me know if you (or anyone else) have any thoughts on this.


On 14/05/18 14:59, William Brown via samba-technical wrote:
>> Attached is a rough set of patches. I still need to tidy a few things
>> up, get some clean autobuilds, and investigate if there's any
>> performance impact. Patches also available via git here:
>> http://git.catalyst.net.nz/gw?p=samba.git;a=shortlog;h=refs/heads/tim
>> -pso
> I think the main thing I'd say is that the netcmd.pso is the wrong
> place. Either it belongs in domain.py, or it needs to become:
> domain/
>     __init__.py
>     pso.py
> Because of the hierarchy of the commands here. 
>> Let me know if anyone has any feedback on the changes at this point.
> Other wise, it's a really long patch set, but a skim read looks pretty
> reasonable. 
>> Thanks,
>> Tim

More information about the samba-technical mailing list