[PATCH: Kerberos keytab bug test and fix]
Andrew Bartlett
abartlet at samba.org
Tue May 15 18:25:03 UTC 2018
On Tue, 2018-05-15 at 18:09 +0200, Andreas Schneider wrote:
> On Tuesday, 15 May 2018 05:09:20 CEST Andrew Bartlett via samba-technical
> wrote:
> > On Tue, 2018-05-15 at 14:17 +1200, Aaron Haslett via samba-technical
> >
> > wrote:
> > > Clearing the keytab with chgtdcpass doesn't work. This test and fix
> > > solves the problem.
> > >
> > > CI tests here:
> > >
> > > https://gitlab.com/catalyst-samba/samba/pipelines/22019771
> >
> > I've improved the all-important whitespace, some coding style issues
> > and commit messages.
> >
> > Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> >
> > https://gitlab.com/catalyst-samba/samba/pipelines/22020990
> > https://gitlab.com/catalyst-samba/samba/commits/aaron-kbtest
> >
> > Can I get a second team reviewer please?
>
> Andrew I missed that there is your RB+ missing for the test. However I've
> pushed it and it landed in master.
>
>
> Could you confirm that you gave RB+ for both patches?
Yes, I'm fine with both patches. Glad to see them in.
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list