[PATCH] Fix CIDs (1435599 and 1435600)

[Volker Lendecke]

On Tue, May 15, 2018 at 07:26:56PM +1000, Amitay Isaacs via samba-technical wrote:
> Hi,
> 
> Patches to fix CIDs in CTDB.  Please review and push.

RB+ on the "match=false" one. For the first one, wouldn't the attached
patch be simpler?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 10811373a0223de90d5945e0bba16e1467a73ad1 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Tue, 15 May 2018 13:28:19 +0200
Subject: [PATCH] ctdb-common: Fix CID 1435600

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 ctdb/common/logging.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ctdb/common/logging.c b/ctdb/common/logging.c
index 3cc19331bab..dc8c4f75058 100644
--- a/ctdb/common/logging.c
+++ b/ctdb/common/logging.c
@@ -173,13 +173,12 @@ static bool file_log_validate(const char *option)
 	dir = dirname(t);
 
 	ret = stat(dir, &st);
+	free(t);
 	if (ret != 0) {
-		free(t);
 		return false;
 	}
 
 	if (! S_ISDIR(st.st_mode)) {
-		free(t);
 		return false;
 	}
 
-- 
2.17.0