[PATCH] LMDB full patch set

Stefan Metzmacher metze at samba.org
Tue May 15 08:06:10 UTC 2018

Am 15.05.2018 um 06:50 schrieb Andrew Bartlett via samba-technical:
> On Mon, 2018-05-14 at 08:02 +0200, Stefan Metzmacher via samba-
> technical wrote:
>> Am 14.05.2018 um 06:59 schrieb Andrew Bartlett via samba-technical:
>>> On Fri, 2018-05-11 at 20:07 +0200, Stefan Metzmacher wrote:
>>>> If it would be optional for sometime and it would actually work
>>>> it would be much easier to agree to push it to master.
>>> I've made it optional.  Builds of ldb and Samba have a --without-ldb-
>>> lmdb option.  Builds --without-ad-dc do not enable lmdb, and only AD DC
>>> sefltest builds require it.
>>> Otherwise, the only other restriction is that 'make test' on ldb is
>>> incompatible with --without-ldb-lmdb.  This pre-empts the 'tests gone
>>> missing' issue.   Both the python and the cmocka tests require lmdb, so
>>> it is clearer to just require it.
>>> The ad_dc and vampire_dc environments in Samba's selftest now use 
>>> --backend-store=mdb
>>> autobuild confirms that ldb will compile --without-ldb-lmdb
>>> If an AD DC build is made against a system ldb without lmdb support,
>>> some tests will fail.  
>>> https://gitlab.com/catalyst-samba/samba/pipelines/21959419
>>> https://gitlab.com/catalyst-samba/samba/commits/metze-master4-lmdb-full
>>> Finally, an ldb make test passes on all the ldb_mdb commits. 
>>> Please review and push ;-)
>> Thanks! I'll have a look later.
> I've reworked the patches to hook this up to the join etc, and the new
> pipeline is here:
> https://gitlab.com/catalyst-samba/samba/pipelines/22016682
>> In the meantime can you please try a private autobuild on sn-devel-144?
> I ran one, it may be due to the number of other autobuilds being run by
> the same user as the ldb tests passed previously but failed now.  
> (So while they all failed, some failed with a different flapping test,
> well past the ldb tests). 
> Are there unusual limits on mmap() areas on that host?
> In the meantime I've updated the error message and dropped the size to
> 8GB for now.  Having this be a relatively fixed number just for sn-
> devel is not ideal however. 

I guess we need to remove the ulimit -v.

On my system top shows this:

29037 metze     39  19 80,238g 109276  38468 S   0,3  0,7   0:22.95 samba


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180515/116963bc/signature.sig>

More information about the samba-technical mailing list