[PATCH] LMDB full patch set

Stefan Metzmacher metze at samba.org
Mon May 14 06:02:48 UTC 2018

Am 14.05.2018 um 06:59 schrieb Andrew Bartlett via samba-technical:
> On Fri, 2018-05-11 at 20:07 +0200, Stefan Metzmacher wrote:
>> If it would be optional for sometime and it would actually work
>> it would be much easier to agree to push it to master.
> I've made it optional.  Builds of ldb and Samba have a --without-ldb-
> lmdb option.  Builds --without-ad-dc do not enable lmdb, and only AD DC
> sefltest builds require it.
> Otherwise, the only other restriction is that 'make test' on ldb is
> incompatible with --without-ldb-lmdb.  This pre-empts the 'tests gone
> missing' issue.   Both the python and the cmocka tests require lmdb, so
> it is clearer to just require it.
> The ad_dc and vampire_dc environments in Samba's selftest now useĀ 
> --backend-store=mdb
> autobuild confirms that ldb will compile --without-ldb-lmdb
> If an AD DC build is made against a system ldb without lmdb support,
> some tests will fail.  
> https://gitlab.com/catalyst-samba/samba/pipelines/21959419
> https://gitlab.com/catalyst-samba/samba/commits/metze-master4-lmdb-full
> Finally, an ldb make test passes on all the ldb_mdb commits. 
> Please review and push ;-)

Thanks! I'll have a look later.

In the meantime can you please try a private autobuild on sn-devel-144?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180514/a11be944/signature.sig>

More information about the samba-technical mailing list