[PATCH: Domain backup samba-tool command]

William Brown william at blackhats.net.au
Mon May 14 05:24:58 UTC 2018

On Mon, 2018-05-14 at 17:06 +1200, Andrew Bartlett wrote:
> On Mon, 2018-05-14 at 12:50 +1000, William Brown via samba-technical
> wrote:
> > On Fri, 2018-03-23 at 17:59 +1300, Aaron Haslett via samba-
> > technical
> > wrote:
> > > The exists shell script for backing up a domain doesn't lock
> > > things
> > > properly while doing the backup and could end up with a corrupt
> > > backup
> > > or cause a lockup.  Here's a new python script that actually
> > > works,
> > > along with tests and required fixes.
> > > 
> > 
> > Hey there,
> > 
> > At a quick glance this looks like a useful feature.
> > 
> > My concern is that you can't assert a backup is succesful unless
> > you
> > can *restore* from it.
> Metze raised essentially the same issue and the restore tool to those
> specifications has been built.  
> We are now just trying to dribble in the patches one at a time as
> they
> parts become ready and as review resources are available.

Yep. I'd be hesitant to provide a "reviewed" until a restore tool
exists too. Can those patches be added to this same set, and be
integrated to the backup tests? 

Don't let this detract from the work though, I think it's great to have
a backup/restore tool, and it's awesome work to have achieved this.
Thanks Aaron!

Maybe I missed it but is this added as part of quicktest? I think it's
important to test backup/restore to guarantee it works (we did this
every build of 389 to at least give confidence this was working as a
minimum baseline), and I think that level of paranoia would be healthy
for s4 dc (It would certainly make me as an admin much happier :) )

Thanks again,


More information about the samba-technical mailing list