[PATCH] LMDB full patch set

Andrew Bartlett abartlet at samba.org
Mon May 14 04:59:51 UTC 2018


On Fri, 2018-05-11 at 20:07 +0200, Stefan Metzmacher wrote:
> If it would be optional for sometime and it would actually work
> it would be much easier to agree to push it to master.

I've made it optional.  Builds of ldb and Samba have a --without-ldb-
lmdb option.  Builds --without-ad-dc do not enable lmdb, and only AD DC
sefltest builds require it.

Otherwise, the only other restriction is that 'make test' on ldb is
incompatible with --without-ldb-lmdb.  This pre-empts the 'tests gone
missing' issue.   Both the python and the cmocka tests require lmdb, so
it is clearer to just require it.

The ad_dc and vampire_dc environments in Samba's selftest now useĀ 
--backend-store=mdb

autobuild confirms that ldb will compile --without-ldb-lmdb

If an AD DC build is made against a system ldb without lmdb support,
some tests will fail.  

https://gitlab.com/catalyst-samba/samba/pipelines/21959419
https://gitlab.com/catalyst-samba/samba/commits/metze-master4-lmdb-full

Finally, an ldb make test passes on all the ldb_mdb commits. 

Please review and push ;-)

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list