[PATCH] samba-tool schema attribute query_oc

Andrew Bartlett abartlet at samba.org
Mon May 14 04:14:59 UTC 2018


On Mon, 2018-05-14 at 14:03 +1000, William Brown via samba-technical
wrote:
> On Mon, 2018-05-14 at 15:09 +1200, Andrew Bartlett wrote:
> > On Mon, 2018-05-14 at 13:02 +1000, William Brown wrote:
> > > 
> > > So that section you mention is documentation, not code. To be sure
> > > of
> > > what you are asking:
> > > 
> > > Do you want the documentation updated to match the bit positions?
> > > 
> > > Or are you asking that the command take the "named bit location"
> > > and
> > > then OR's the result to create the schema behaviour value? IE:
> > 
> > Yes.
> > 
> > > /usr/local/samba/bin/samba-tool schema attribute modify --
> > > searchflags="fATTINDEX,fSUBTREEATTINDEX,fCONFIDENTIAL"
> > > 
> > > I suspect this is your request, but I want to be sure,
> > 
> > Correct, something like that.
> > 
> > Andrew Bartlett
> > 
> 
> Thanks mate! I've done exactly this. The changes are in 0005-python-
> samba-netcmd-schema.py-add-schema-query-and-m.patch
> 
> You'll also note I've updated the test cases to check for invalid
> flags, wrong capitialisation, the --help is updated, and two extra
> flags are added to ms_schema. 
> 
> Once again, the 6 patches attached (sorry, I forgot the trick you
> showed me to get these into a single file)

--stdout.

The other thing I requested previously is to trim the list down to (or
at the very least mark) those flags we in Samba actually honour.  For
example, we always do a one-level index, so that flag is never used.

Also, on the show command, do the reverse mapping back to the string
flags.

Finally, you seem to be looking for ldb.get_schema_basedn() with your
patch to samdb.py.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list