[PATCH: Domain backup samba-tool command]

William Brown william at blackhats.net.au
Mon May 14 02:50:12 UTC 2018

On Fri, 2018-03-23 at 17:59 +1300, Aaron Haslett via samba-technical
> The exists shell script for backing up a domain doesn't lock things
> properly while doing the backup and could end up with a corrupt
> backup
> or cause a lockup.  Here's a new python script that actually works,
> along with tests and required fixes.

Hey there,

At a quick glance this looks like a useful feature.

My concern is that you can't assert a backup is succesful unless you
can *restore* from it. So I think if this is to be submitted a proper
restore tool is required as well. The restore tool should indicate the
risks of restoring a DC also (mainly that you have to reset every DC in
the topology to be a new replica from the restore). 

I think that a matching restore tool is needed to make sure that your
backup command really does work. Else it's sadly just hopes and dreams.

With this in mind, I don't think I'm willing to give a "review" until a
matching restore tool is added. Remember, backups don't exist unless
they are tested as operational. 

Sorry, :( 


More information about the samba-technical mailing list