py2/py3 patches reviewed

github at samba.org github at samba.org
Sat May 12 19:39:42 UTC 2018


New comment by abartlet on Samba Github repository

https://github.com/samba-team/samba/pull/185#issuecomment-388578089
Comment:
The Cstring patch needs to be after or alongside the DNS patch I dropped, or else the build fails.

In general try it is best if the patches all pass make test (in theory, there isn't an automated check for this part) to aid a git bisect or dropping patches from the series like I have.


More information about the samba-technical mailing list