[PATCH] Add config file handling to CTDB (finally!)
martin at meltin.net
Sat May 12 09:04:13 UTC 2018
On Sat, 12 May 2018 18:29:58 +1000, Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:
> On Sat, 12 May 2018 14:31:07 +1000, Amitay Isaacs via samba-technical
> <samba-technical at lists.samba.org> wrote:
> > Here is a patch set that adds config file handling to CTDB. The conf
> > api allows to define configuration options and validation functions
> > for each component. This also adds a configuration validation tool.
> > The idea is to centralize all CTDB configuration. The config file will
> > follow the samba config file format. This will allow us to get rid of
> > the adhoc configuration file handling via ctdbd_wrapper for main ctdbd
> > and event scripts.
> > Other things in the patch set are:
> > - abstraction to handle command-line options and commands/arguments for tools
> > - abstraction for all the paths (also handles them for testing)
> > All the testing now will be based on CTDB_TEST_MODE and the paths will
> > be based on CTDB_BASE.
> > Please review and push.
> Reviewed-by: Martin Schwenke <martin at meltin.net>
> I did 2 very minor things:
> * Added your Reviewed-by: tag to the "Add config options for logging"
> commit with my authorship. I can't imagine this being an issue
> because you've looked through it many times and you posted it. ;-)
> * Removed a blank line from the end of path_tool.c
[235/367] Compiling tests/src/conf_test.c
../tests/src/conf_test.c: In function ‘main’:
../tests/src/conf_test.c:458:1: error: control reaches end of non-void function [-Werror=return-type]
The old version of gcc on sn-devel hasn't read the C standard! ;-)
I added the obvious "return 0;" at the end of main() and re-pushed.
peace & happiness,
More information about the samba-technical