[PATCH] Prepare for samba-tool domain backup (including fixing chgtdcpass)

Garming Sam garming at catalyst.net.nz
Fri May 11 09:42:35 UTC 2018


Hi,

They look fine to me, although I may have removed the backupDate patch 
from the set. If you're fine with it, then you can push it to autobuild.

Reviewed-by: Garming Sam <garming at catalyst.net.nz>

Cheers,

Garming

On 11/05/2018 3:43 PM, Andrew Bartlett via samba-technical wrote:
> Attached please find some patches developed by Aaron Haslett earlier in
> aid of a new samba-tool domain backup command.
>
> The actual command isn't done yet (xattrs need to be sorted out I'm
> told) but these preparation patches can go in.
>
> https://gitlab.com/catalyst-samba/samba/commits/abartlet-backuptool-for-master
>
> CI results are here:
> https://gitlab.com/catalyst-samba/samba/pipelines/21847265
>
> An important fix here is for this bug
> https://bugzilla.samba.org/show_bug.cgi?id=13415
>
> The chgtdcpass script used by some administrators to wipe old keys from
> the keytab did not actually work.
>
> Aaron found this out when using this command to test the backup.
>
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>
> Can I get a second team reviewer please?
>
> Thanks,
>
> Andrew Bartlett
>




More information about the samba-technical mailing list