[PATCH] cifs/smb3: directory sync should not return an error

Jeremy Allison jra at samba.org
Thu May 10 22:12:48 UTC 2018

On Fri, May 11, 2018 at 08:08:46AM +1000, ronnie sahlberg wrote:
> MS-SMB2.pdf  is pretty clear that FLUSH can only be used on files or pipes.
> If we start using it for directory handles we would need some
> clarifications about this use in the spec.

Yes. MS-SMB2 is also wrong :-).

I have test code that proves FLUSH works against any directory
handle opened with FILE_ADD|DIRECTORY_ADD access mask granted.

(Steve thought this might be special cased to just the root
directory handle on a share, this turns out not to be the
case - any directory handle with the required access works

> I would wait until MS-SMB2 is updated before we start sending FLUSH on
> directory handles.

We need to deal with the protocol as it really is,
not as the documentation would like it to be :-).


More information about the samba-technical mailing list