[PATCH] Fix smbd behavior with SMB2-FLUSH on a directory handle.

jim jim.brown at rsmas.miami.edu
Thu May 10 18:41:03 UTC 2018


Jeremy

Why is this new test a knownfail? Add a comment to this line?
+^samba3.smbtorture_s3.*ad_dc_ntvfs.*SMB2-DIR-FSYNC.*

Jim

On 5/10/2018 2:36 PM, Jeremy Allison via samba-technical wrote:
> After testing against Windows it turns out that
> SMB2-FLUSH should succeed on a handle opened
> with FILE_ADD_FILE|FILE_ADD_SUBDIRECTORY
> access.
>
> Works on UNIX too, as fsync(fd) can
> be called against an open directory
> handle to sync the metadata on disk.
>
> Added a regression test that enabled
> me to understand how Windows behaves,
> we now pass it.
>
> BUG: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.samba.org%2Fshow_bug.cgi%3Fid%3D13428&data=02%7C01%7Cjim.brown%40miami.edu%7C3dff933832134e9dfa7308d5b6a4f37c%7C2a144b72f23942d48c0e6f0f17c48e33%7C0%7C1%7C636615741951668313&sdata=9OIzfLiWmQnibjtVkI0UsnNf2jYCbOYhzmcKvhSSVtE%3D&reserved=0
>
> Please review and push if happy !
>
> Cheers,
>
> 	Jeremy.




More information about the samba-technical mailing list