[PATCH] make --with-{gpgme,json-audit,libarchive} the default, finish --without-json-audit docs

Andrew Bartlett abartlet at samba.org
Thu May 10 02:11:01 UTC 2018

Based on a discussion deep in the --with-json-audit thread.

This patch set makes the --with-{gpgme,json-audit,libarchive} options
the default.

This means that those wishing to build an AD DC without gpgme need to
set --without-gpgme at configure time, rather than this being auto-

Likewise, those not wanting JSON-formatted audit logs to be available
need to use --without-json-audit and those wanting a less-full-featured 
smbclient can use --without-libarchive.

Naturally all those features are still subject to run-time

This is consistent with the default of --with-ldap and --with-ads,
which has had this behaviour for a number of years.

The rationale is that it makes the documentation easier to follow
(avoids saying 'if xxx was detected' which can be difficult for an end
user to determine) and ensures that features don't go missing
accidentally.  (This can happen due to changes in build environments,
particularly when building packages.  We address this by forcing an
explicit choice rather than auto-detecting.)

For json-audit, I've taken Rowland's proposed text and added to the
smb.conf manpage as per Björn's earlier effort. 

(I do not claim this small step is comprehensive, it just makes us one
step closer). 

Finally, I require libarchive for sefltest, avoiding the opportunity
for these tests to go missing as others under similar conditionals have

The CI results will be here:

The branch is here:

Please review/push!

Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list