[PATCH] vfs_ceph: add fake async pwrite/pread send/recv hooks
jra at samba.org
Wed May 9 17:15:19 UTC 2018
On Wed, May 09, 2018 at 06:52:38PM +0200, Ralph Böhme wrote:
> On Wed, May 09, 2018 at 09:03:10AM -0700, Jeremy Allison via samba-technical wrote:
> > On Wed, May 09, 2018 at 05:07:11PM +0200, David Disseldorp wrote:
> > > As found by Jeremy, VFS modules that don't provide pread_send() or
> > > pwrite_send() hooks result in vfs_default fallback, which is
> > > catastrophic for VFS modules with non-mounted filesystems such as
> > > vfs_ceph.
> > >
> > > Bug: https://bugzilla.samba.org/show_bug.cgi?id=13425
> > Thanks a lot David, you just did the work I was planning
> > to do today for me :-).
> > RB+ and pushed !
> But wait a minute: bytes_read is ssize_t, but ceph_read|write seem to return an
> int. Is this really correct?
Yep, seems so:
grep ceph_read /usr/include/*/*.h
/usr/include/cephfs/libcephfs.h:int ceph_read(struct ceph_mount_info *cmount, int fd, char *buf, int64_t size, int64_t offset);
More information about the samba-technical