[PATCH] Remove unused se_create_child_secdesc_buf()

Ralph Böhme slow at samba.org
Wed May 9 08:16:36 UTC 2018


Hi!

This removes an unused function.

Please review & push if happy. Thanks!

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46
-------------- next part --------------
From 7130185dab76601155e5d344f598e6cc75593fb0 Mon Sep 17 00:00:00 2001
From: Ralph Boehme <slow at samba.org>
Date: Wed, 9 May 2018 10:14:37 +0200
Subject: [PATCH] libcli: remove unused se_create_child_secdesc_buf()

Commit e2c9ad93cb914186b89e2055f1bed3cceee1f768 removed the last caller
of this.

Signed-off-by: Ralph Boehme <slow at samba.org>
---
 libcli/security/secdesc.c | 28 ----------------------------
 libcli/security/secdesc.h |  4 ----
 2 files changed, 32 deletions(-)

diff --git a/libcli/security/secdesc.c b/libcli/security/secdesc.c
index 6e20e90bee5..8cf44347c7c 100644
--- a/libcli/security/secdesc.c
+++ b/libcli/security/secdesc.c
@@ -636,31 +636,3 @@ NTSTATUS se_create_child_secdesc(TALLOC_CTX *ctx,
 	}
 	return NT_STATUS_OK;
 }
-
-NTSTATUS se_create_child_secdesc_buf(TALLOC_CTX *ctx,
-					struct sec_desc_buf **ppsdb,
-					const struct security_descriptor *parent_ctr,
-					bool container)
-{
-	NTSTATUS status;
-	size_t size = 0;
-	struct security_descriptor *sd = NULL;
-
-	*ppsdb = NULL;
-	status = se_create_child_secdesc(ctx,
-					&sd,
-					&size,
-					parent_ctr,
-					parent_ctr->owner_sid,
-					parent_ctr->group_sid,
-					container);
-	if (!NT_STATUS_IS_OK(status)) {
-		return status;
-	}
-
-	*ppsdb = make_sec_desc_buf(ctx, size, sd);
-	if (!*ppsdb) {
-		return NT_STATUS_NO_MEMORY;
-	}
-	return NT_STATUS_OK;
-}
diff --git a/libcli/security/secdesc.h b/libcli/security/secdesc.h
index 34d9d77b4b4..dd8cf4ed716 100644
--- a/libcli/security/secdesc.h
+++ b/libcli/security/secdesc.h
@@ -97,9 +97,5 @@ NTSTATUS se_create_child_secdesc(TALLOC_CTX *ctx,
 					const struct dom_sid *owner_sid,
 					const struct dom_sid *group_sid,
 					bool container);
-NTSTATUS se_create_child_secdesc_buf(TALLOC_CTX *ctx,
-					struct sec_desc_buf **ppsdb,
-					const struct security_descriptor *parent_ctr,
-					bool container);
 
 #endif /* _SECDESC_H_ */
-- 
2.13.6



More information about the samba-technical mailing list