Memory leak in cephwrap_realpath (vfs_ceph.c)

[Jeremy Allison]

On Mon, May 07, 2018 at 11:11:42AM +0200, David Disseldorp via samba-technical wrote:
> Hi Vandana,
> 
> On Sun, 6 May 2018 16:53:30 +0000, Rungta, Vandana via samba-technical wrote:
> 
> > There are a couple of memory leak issues in cephwrap_realpath in vfs_ceph.c
> > 
> > 
> >   1.  “result” is double allocated by  SMB_MALLOC_ARRAY and by asprintf .
> >   2.  The error code paths for r < 0 need to SAFE_FREE “result”.
> 
> Thanks for the report, your analysis looks correct to me.
> Could you please resend your patch as an attachment or git pull URL, as
> the inline version seems to be malformed.
> Also, please add your sign-off to the commit.

Here is a (slightly) modified version with attached
bug report:

https://bugzilla.samba.org/show_bug.cgi?id=13424

Vandana, I'm happy to make this your 'Signed-off-by:'
if you want, let me know.

Please review and push if happy !

Cheers,

	Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-VFS-Fix-memory-leak-in-vfs_ceph.patch
Type: text/x-diff
Size: 1945 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180508/b6fdba25/0001-s3-VFS-Fix-memory-leak-in-vfs_ceph.diff>