[PATCH] Fix a Coverity finding
Volker Lendecke
Volker.Lendecke at SerNet.DE
Tue May 8 06:42:58 UTC 2018
Hi!
Review appreciated!
Thanks, Volker
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From e5c6482605aae076cbc26a725ce508ce0dcbb90e Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Tue, 8 May 2018 08:35:18 +0200
Subject: [PATCH] dsdb: Fix CID 1435453 Null pointer dereferences
Signed-off-by: Volker Lendecke <vl at samba.org>
---
source4/dsdb/samdb/ldb_modules/schema_load.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/source4/dsdb/samdb/ldb_modules/schema_load.c b/source4/dsdb/samdb/ldb_modules/schema_load.c
index fd19d105162..6a3001d05e4 100644
--- a/source4/dsdb/samdb/ldb_modules/schema_load.c
+++ b/source4/dsdb/samdb/ldb_modules/schema_load.c
@@ -82,6 +82,10 @@ static int schema_metadata_open(struct ldb_module *module)
filename = ldb_relative_path(ldb,
tmp_ctx,
"sam.ldb.d/metadata.tdb");
+ if (filename == NULL) {
+ talloc_free(tmp_ctx);
+ return ldb_module_oom(module);
+ }
open_flags = O_RDWR;
if (stat(filename, &statbuf) != 0) {
--
2.11.0
More information about the samba-technical
mailing list