[PATCH] LMDB full patch set

Stefan Metzmacher metze at samba.org
Mon May 7 15:57:35 UTC 2018

Am 07.05.2018 um 05:02 schrieb Andrew Bartlett via samba-technical:
> On Fri, 2018-05-04 at 22:42 +1200, Andrew Bartlett wrote:
>> On Fri, 2018-05-04 at 06:52 +1200, Andrew Bartlett via samba-technical
>> wrote:
>>> On Thu, 2018-05-03 at 16:46 +0200, Stefan Metzmacher wrote:
>>>> I'll try to have another look when you give me the pointers to
>>>> rebased branches.
>>> Thanks.  My plan for today (now that I'm past the flapping test) is to
>>> do exactly that, there just wasn't time once I got the LSA thing done. 
>> I've finally got a set of patches I'm happy with here:
>> https://gitlab.com/catalyst-samba/samba/commits/metze-master4-lmdb-full
> These have passed a full autobuild in the gitlab CI here:
> https://gitlab.com/catalyst-samba/samba/pipelines/21509189
> (for the previous set) and here:
> https://gitlab.com/catalyst-samba/samba/pipelines/21600415
> (for the current set)
> The diff against a (very rough) rebase of the previous patches I posted
> is attached, just to highlight the areas of change.  (That is, don't
> worry about the 'wrong' stuff in the ldb_ldb stuff, it is right in the
> actual patches).
> Every patch passes a full make test in lib/ldb.
> Gary/Garming,
> Can you confirm you are happy with the review tags and review my extra
> tests?
> Metze,
> I've addressed your concerns as far as practical[1].  If you could
> please allow this to proceed into master I would most appreciate it. 

Can you move all tdb related patch to the start of the patchset,
they should work on their own. Also the fork protection tests.

I don't see where ldb_tdb_test is used in tests...

From reading the patches it seems that it will no longer possible
to build ldb or an AD DC without lmdb, e.g. 32bit support will be gone.
I don't think that's acceptable right now, maybe in a few years.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180507/9413eb48/signature.sig>

More information about the samba-technical mailing list