[PATCH] Add utilities to check style

Ralph Böhme slow at samba.org
Mon May 7 13:47:18 UTC 2018


On Mon, May 07, 2018 at 08:11:43AM -0400, Simo wrote:
> On Sun, 2018-05-06 at 21:54 +0200, Ralph Böhme wrote:
> > On Sun, May 06, 2018 at 01:22:05PM -0400, Simo wrote:
> > > I fetched this branch but there is
> > > no 54f124f39bc5ae316faab97e2ee2d00c3b8cfe44
> > > 
> > > so I can't test it.
> > 
> > hm, maybe I forgot to push the snapshot of the branch. The branch "tmp" now
> > points at commit 54f124f39bc5ae316faab97e2ee2d00c3b8cfe44.
> 
> Thanks,
> If my coffee is strong enough this morning :-) I think the error is
> here: "Jean Fran\xe7ois Micouleau"
>
> It think this has been copied over and over since back then when code
> pages were used instead of utf8.
> 
> There are 6 files in the tree with invalid utf8 characters in Jean
> François name. A patch is attached to fix that.
> 
> Please RB+ and push this patch, first win for the style checker,
> although it found an encoding issue rather than a style one :-)

:)

Pushed. Thanks!

I'll retest my WIP branches with the style checker one this fix is in master.

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46



More information about the samba-technical mailing list