[PATCH] Add utilities to check style

[Simo]

On Thu, 2018-05-03 at 19:46 +0200, Ralph Böhme via samba-technical
wrote:
> On Thu, May 03, 2018 at 09:41:42AM -0400, Simo wrote:
> > On Thu, 2018-04-26 at 15:31 -0400, Simo via samba-technical wrote:
> > > On Thu, 2018-04-26 at 11:54 -0700, Jeremy Allison via samba-technical
> > > wrote:
> > > > On Thu, Apr 26, 2018 at 02:49:02PM -0400, Simo wrote:
> > > > > 
> > > > > As I said README.Config contradicts itself, it says one thing but
> > > > > points to an indent tool that does another.
> > > > > 
> > > > > So far You raised concerns about clarifying this rule in favor of what
> > > > > the indent tool does, while Jeremy supported the opposite.
> > > > > 
> > > > > I am not married to either really, but I also prefer the { always on
> > > > > the same line. I think we need to decide which way to go.
> > > > > 
> > > > > Anyone else has opinions ?
> > > > 
> > > > You know what they say about opinions :-). Yeah, I guess
> > > > this is just a style thing - you and I like it one way,
> > > > Ralph likes another. In those cases we should probably
> > > > allow both IMHO.
> > > 
> > > Ok, I am going to strip any checking for parens then
> > > because both == no stlye == no check we can enforce.
> > > 
> > > Attached find a patch with the check disabled (but the code is changed
> > > to reflect my last proposal, so if we change mind at least we have the
> > > code ready to be used).
> > 
> > Bump,
> > 
> > Jeremy, Ralph,
> > is this version ok ?
> 
> with commit 54f124f39bc5ae316faab97e2ee2d00c3b8cfe44 from this branch:
> <https://git.samba.org/?p=slow/samba.git;a=shortlog;h=refs/heads/ph-smb>
> 
> I'm getting a fatal error:
> 
> $ script/cstyle.py 54f124f39bc~1..54f124f39bc
> 54f124f39bc dbwrap: add flags arg to dbwrap_fetch_locked() and dbwrap_try_fetch_locked()
> Unexpected command failure:
> UnicodeDecodeError(... , 161, 162, 'invalid continuation byte')
> 
> I have no idea what triggers this. Can you check?

I fetched this branch but there is
no 54f124f39bc5ae316faab97e2ee2d00c3b8cfe44

so I can't test it.
Simo.