[PATCHES v2] Re: [PATCHES] fix bugs in the python bindings

[Douglas Bagnall]

On 03/05/18 17:36, Douglas Bagnall via samba-technical wrote:
> There was a mistake lurking in there. New version attached.

OK, there are still problems, so I will look again next week.

Douglas

> 
> On 03/05/18 16:40, William Brown wrote:
>> On Thu, 2018-05-03 at 16:12 +1200, Douglas Bagnall via samba-technical
>> wrote:
>>> Procrastinating again, I found a number of segfaults and a seemingly
>>> endless series of memory leaks and unchecked allocations in the
>>> Python
>>> bindings. I managed to stop myself after the attached patches.
>>>
>>> Douglas
>>
>> Most of this looks sane to me. It's a pretty big patch though. I'd want
>> to run it with ASAN to be sure, but that may highlight more outstanding
>> cases.
> 
> Yep. There are also about a million outstanding cases I don't think it
> will catch, namely the lack of Py_DECREF()s and failures to consider
> NULL values from Python allocations. Given the way we use Python in
> short-lived little processes, those are annoying but not really interesting.
> 
> Douglas
>