[PATCH] build: add option to choose to build with or without JSON audit support

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri May 4 03:55:51 UTC 2018

On Fri, May 04, 2018 at 08:23:30AM +1200, Andrew Bartlett via samba-technical wrote:
> On Thu, 2018-05-03 at 21:47 +0200, Volker Lendecke wrote:
> > On Thu, May 03, 2018 at 08:27:08PM +1200, Andrew Bartlett via samba-technical wrote:
> > > On Thu, 2018-05-03 at 09:22 +0100, Rowland Penny via samba-technical
> > > wrote:
> > > > 
> > > > I feel, 'Samba was not compiled with --without-json-audit' is clearer
> > > 
> > > Thanks Rowland.  I agree, but I have to make that true first.  A task
> > > for Monday (I hope to slay LMDB tomorrow). 
> > 
> > I might be late in the game. I just tried to compile --without-ad-dc,
> > but still get a link dependency against libjansson. What is that used
> > for without having an Active Directory Domain Controller even
> > compiled? Why is libjansson a strict dependency in that case? Are we
> > using it for other things now also?
> The audit logging was added for the file server and NT4 DC as well.  
> The testing and coverage is comprehensive for the AD DC, but where the
> same paths are used (and where it wasn't hard to add) the file server
> and NT4 DC wasn't left out.  
> My hope is that this can be quite helpful in monitoring large
> installations. 

Ok, but the only way to not link against this is to remove
libjansson-dev from the build machine, right? This means a build
machine per target environment. Easy with containers. Thanks for the

I thought we had removed Javascript in favor of python years ago. I
don't understand why are forced to pull it in again now. Do you plan
to replace our python scripting by Javascript also in the future?


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list