Allow make test with ASan / --address-sanitizer
william at blackhats.net.au
Fri May 4 01:35:13 UTC 2018
On Fri, 2018-05-04 at 13:00 +1200, Gary Lockyer via samba-technical
> I've had a little play with this, it does blow out the test run times
> the order of 5 to 6 times. And there do appear to be issues, I
> don't have the time to chase these down.
The extra time is expected - it is intercepting your malloc/free calls
Given that we now have the ability to run this, it makes it easier to
pick up the issues later, it's good enough that we have the ability to
find these now.
> On 03/05/18 20:18, Alexander Bokovoy via samba-technical wrote:
> > On to, 03 touko 2018, Andrew Bartlett via samba-technical wrote:
> > > On Thu, 2018-05-03 at 16:35 +1200, Andrew Bartlett via samba-
> > > technical
> > > wrote:
> > > > I needed to get AddressSanitizer working to fix the LSA use-
> > > > after-free
> > > > bug and the attached make it all work again.
> > > >
> > > > Recent versions of GCC require that the library be in
> > > > LD_PRELOAD before
> > > > anything that is linked with libasan. I use a horrible ldd
> > > > hack to
> > > > find the right library path (sorry, not sorry).
> > > >
> > > > Once we get a more modern sn-devel I'll enable this by default
> > > > in
> > > > autobuild.
> > >
> > > And this patch allows a developer build with --address-sanitizer
> > > enabled.
> > >
> > > Please review this also.
> > LGTM.
> > Pushed to autobuild.
More information about the samba-technical