Fwd: [PATCHES] simple gpo patches fixes
douglas.bagnall at catalyst.net.nz
Thu May 3 23:12:39 UTC 2018
On 01/05/18 08:06, David Mulder via samba-technical wrote:
> On 04/18/2018 04:01 PM, Douglas Bagnall via samba-technical wrote:
>> Now I'm noticing there are no tests for gpo.check_refresh_gpo_list() at all,
>> which there should be.
> Yes, there is no test. I just tried adding one, but
> check_refresh_gpo_list() dies when trying to call cli_full_connection(),
> which is odd. Dies in the test env, but works fine outside. I'll post
> later when I get this working.
>> It would be *slightly* better to use an immutable tuple rather than a list,
>> and better still to have an opaque object from python's point of view. The
>> real solution would be to iterate through and reconstruct the linked list
>> from the Python list.
> Ok, I've fixed this now.
Right, that looks good! So it just needs that test.
More information about the samba-technical