[PATCH] Add utilities to check style
Ralph Böhme
slow at samba.org
Thu May 3 13:54:18 UTC 2018
On Thu, May 03, 2018 at 09:41:42AM -0400, Simo wrote:
> On Thu, 2018-04-26 at 15:31 -0400, Simo via samba-technical wrote:
> > On Thu, 2018-04-26 at 11:54 -0700, Jeremy Allison via samba-technical
> > wrote:
> > > On Thu, Apr 26, 2018 at 02:49:02PM -0400, Simo wrote:
> > > >
> > > > As I said README.Config contradicts itself, it says one thing but
> > > > points to an indent tool that does another.
> > > >
> > > > So far You raised concerns about clarifying this rule in favor of what
> > > > the indent tool does, while Jeremy supported the opposite.
> > > >
> > > > I am not married to either really, but I also prefer the { always on
> > > > the same line. I think we need to decide which way to go.
> > > >
> > > > Anyone else has opinions ?
> > >
> > > You know what they say about opinions :-). Yeah, I guess
> > > this is just a style thing - you and I like it one way,
> > > Ralph likes another. In those cases we should probably
> > > allow both IMHO.
> >
> > Ok, I am going to strip any checking for parens then
> > because both == no stlye == no check we can enforce.
> >
> > Attached find a patch with the check disabled (but the code is changed
> > to reflect my last proposal, so if we change mind at least we have the
> > code ready to be used).
>
> Bump,
>
> Jeremy, Ralph,
> is this version ok ?
> If so can you RB and push to autobuild ?
sorry. I'll give it a whirl later on with my largish WIP persistent handles
branches and will report back.
-slow
--
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
GPG Key Fingerprint: FAE2 C608 8A24 2520 51C5
59E4 AA1E 9B71 2639 9E46
More information about the samba-technical
mailing list