[PATCH] ldbndr: Include context for error strings in ndr_check_array_{size,length}() and ndr_pull_array_length()

Andrew Bartlett abartlet at samba.org
Thu May 3 03:02:28 UTC 2018

On Thu, 2018-05-03 at 14:35 +1200, William Brown wrote:
> On Thu, 2018-05-03 at 12:13 +1200, Andrew Bartlett via samba-technical
> wrote:
> > I'm trying to track down the new AD DC LSA failure.  The attached
> > patch
> > may help us locate what is behind the failure and provide useful
> > debugging into the future.
> > 
> > Please review and push.
> > 
> > Andrew Bartlett
> Pushing char pointers around when you have only a handful of
> predetermined combinations seems a bit overkill? Why not only provide a
> single char identifier and then use the error message to determine the
> fault?

It probably isn't clear, but the PIDL code generator calls this from
almost every DCE/RPC structure.  I was thinking to include __location__
as well but didn't yet.

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list