[PATCH] ldbndr: Include context for error strings in ndr_check_array_{size,length}() and ndr_pull_array_length()
William Brown
william at blackhats.net.au
Thu May 3 02:35:15 UTC 2018
On Thu, 2018-05-03 at 12:13 +1200, Andrew Bartlett via samba-technical
wrote:
> I'm trying to track down the new AD DC LSA failure. The attached
> patch
> may help us locate what is behind the failure and provide useful
> debugging into the future.
>
> Please review and push.
>
> Andrew Bartlett
Pushing char pointers around when you have only a handful of
predetermined combinations seems a bit overkill? Why not only provide a
single char identifier and then use the error message to determine the
fault?
Otherwise it all looks pretty sane and good to me.
Thanks,
William
More information about the samba-technical
mailing list