[PATCH] Extend autobuild combinations to include --without-ldap

Andrew Bartlett abartlet at samba.org
Wed May 2 22:53:56 UTC 2018

Sonic, posting on the samba list, noticed recently that --without-ldap
builds fail, so this patch ensures that one of the builds we do is with
this set so that we  catch that. 

I've compared the test output and no tests have been lost due to this.

Please review and push.


Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

-------------- next part --------------
From acbf433b8db4a0a51c3944cff516260950d6cc46 Mon Sep 17 00:00:00 2001
From: Andrew Bartlett <abartlet at samba.org>
Date: Wed, 2 May 2018 09:04:51 +1200
Subject: [PATCH] autobuild: Extend build combinations tested to include

This bumps --without-ads to the samba-nt4 job so that option alone is still covered.

Signed-off-by: Andrew Bartlett <abartlet at samba.org>
 script/autobuild.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/script/autobuild.py b/script/autobuild.py
index e00eebda1c1..0ac65f138f1 100755
--- a/script/autobuild.py
+++ b/script/autobuild.py
@@ -121,7 +121,7 @@ tasks = {
                 ("clean", "make clean", "text/plain") ],
     # We split out this so the isolated nt4_dc tests do not wait for ad_dc or ad_dc_ntvfs tests (which are long)
-    "samba-nt4" : [ ("configure", "./configure.developer --with-selftest-prefix=./bin/ab" + samba_configure_params, "text/plain"),
+    "samba-nt4" : [ ("configure", "./configure.developer --without-ads --with-selftest-prefix=./bin/ab" + samba_configure_params, "text/plain"),
                        ("make", "make -j", "text/plain"),
                        ("test", "make test FAIL_IMMEDIATELY=1 TESTS='--include-env=nt4_dc --include-env=nt4_member'", "text/plain"),
                        ("install", "make install", "text/plain"),
@@ -130,7 +130,7 @@ tasks = {
     # We split out this so the isolated ad_dc tests do not wait for ad_dc_ntvfs tests (which are long)
     "samba-fileserver" : [ ("random-sleep", "../script/random-sleep.sh 60 600", "text/plain"),
-                      ("configure", "./configure.developer --without-ad-dc --without-ads --with-selftest-prefix=./bin/ab" + samba_configure_params, "text/plain"),
+                      ("configure", "./configure.developer --without-ad-dc --without-ldap --without-ads --with-selftest-prefix=./bin/ab" + samba_configure_params, "text/plain"),
                       ("make", "make -j", "text/plain"),
                       ("test", "make test FAIL_IMMEDIATELY=1 TESTS='--include-env=fileserver'", "text/plain"),
                       ("check-clean-tree", "script/clean-source-tree.sh", "text/plain")],

More information about the samba-technical mailing list