[PATCH] build: add option to choose to build with or without JSON audit support

Björn Baumbach bb at sernet.de
Wed May 2 11:43:07 UTC 2018

On 04/29/2018 08:53 PM, Andrew Bartlett wrote:
> On Tue, 2018-04-17 at 15:59 +0200, Björn Baumbach via samba-technical
> wrote:
>> Hi!
>> I've prepared an option to disable or enforce the build with support for
>> JSON auth audit, which needs the jansson library.
>> By default the jansson library is auto-detected and is then used for the
>> JSON auth audit method.
>> Review is appreciated!
> I realise this is already in, but could we please have the default
> being True?  It is correct that this is the no-change behaviour, but on
> reflection we have made many other things bug the user to install
> packages or explicitly disable the feature, and doing so would ensure
> that more packages and more installs get to use this functionality.  
> (Because folks doing the build are prompted).
> Either way, the smb.conf manpage section also needs to be updated.

Hi Andrew,

I didn't change the behaviour. The default is still the auto-detection.
In my opinion this feature is an optional feature and I am fine with the
current default. I would not like to set the default to True.

In which way would you like to update the man page? The condition "if
Samba is compiled against the jansson JSON library" is still correct here:

  Authentication and authorization audit information is logged under
  the auth_audit, and if Samba is compiled against the jansson JSON
  library, a JSON representation is logged under auth_json_audit.

Best regards,

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list